Skip to content

Use WRAP_LIMIT to limit the width of tooltip signatures #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: net233
Choose a base branch
from
Open

Use WRAP_LIMIT to limit the width of tooltip signatures #542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2d638e
Use WRAP_LIMIT to limit the width of tooltip signatures
dawedawe Jul 5, 2023
d731d00
divide WRAP_LIMIT by 3
dawedawe Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ReSharper.FSharp/src/FSharp.Psi.Daemon/src/QuickDoc/FSharpQuickDocProvider.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ module JetBrains.ReSharper.Plugins.FSharp.Psi.Daemon.QuickDoc
open FSharp.Compiler.EditorServices
open FSharp.Compiler.Tokenization
open JetBrains.Application.DataContext
open JetBrains.Application.Settings
open JetBrains.DocumentModel.DataContext
open JetBrains.ReSharper.Daemon
open JetBrains.ReSharper.Feature.Services.QuickDoc
open JetBrains.ReSharper.Plugins.FSharp.Psi
open JetBrains.ReSharper.Plugins.FSharp.Psi.Features
open JetBrains.ReSharper.Plugins.FSharp.Psi.Tree
open JetBrains.ReSharper.Plugins.FSharp.Services.Formatter
open JetBrains.ReSharper.Plugins.FSharp.Util.FcsTaggedText
open JetBrains.ReSharper.Psi.DataContext
open JetBrains.ReSharper.Psi.Files
Expand All @@ -31,7 +33,11 @@ module FSharpQuickDoc =
// todo: provide tooltip for #r strings in fsx, should pass String tag
let line = int coords.Line + 1
let column = int coords.Column
Some(results.CheckResults.GetToolTip(line, column, lineText, tokenNames, FSharpTokenTag.Identifier))

let settingsStore = token.GetSettingsStoreWithEditorConfig()
let wrapLimit = settingsStore.GetValue(fun (key: FSharpFormatSettingsKey) -> key.WRAP_LIMIT) / 3

Some(results.CheckResults.GetToolTip(line, column, lineText, tokenNames, FSharpTokenTag.Identifier, wrapLimit))


type FSharpQuickDocPresenter(xmlDocService: FSharpXmlDocService, identifier: IFSharpIdentifier) =
Expand Down