Skip to content

Improve the typing for iterator_to_array #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve the typing for iterator_to_array #1821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e682c10
Improve the typing for iterator_to_array
yottalogical Nov 19, 2025
6210d5a
Handle the case when $preserve_keys could be true or false
yottalogical Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions SPL/SPL_f.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,15 +139,19 @@ function spl_object_hash(object $object): string {}
/**
* Copy the iterator into an array
* @link https://php.net/manual/en/function.iterator-to-array.php
* @template TKey
* @template TKey of int|string
* @template TValue
* @param Traversable<TKey, TValue> $iterator <p>
* @param Traversable<TKey, TValue>|array<TKey, TValue> $iterator <p>
* The iterator being copied.
* </p>
* @param bool $preserve_keys [optional] <p>
* Whether to use the iterator element keys as index.
* </p>
* @return array<TKey, TValue>|TValue[] An array containing the elements of the iterator.
* @return (
* $preserve_keys is true ? array<TKey, TValue> : (
* $preserve_keys is false ? TValue[] :
* array<TKey, TValue>|TValue[])
* ) An array containing the elements of the iterator.
*/
function iterator_to_array(#[LanguageLevelTypeAware(['8.2' => 'Traversable|array'], default: 'Traversable')] $iterator, bool $preserve_keys = true): array {}

Expand Down
Loading