Skip to content

Add #[Pure] to mbstring PHP 8.4 methods #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add #[Pure] to mbstring PHP 8.4 methods #1793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions mbstring/mbstring.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1419,26 +1419,37 @@ function mb_str_split(string $string, int $length = 1, ?string $encoding) {}
/**
* @since 8.3
*/
#[Pure]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alies-dev Shouldn't the functions be marked as #[Pure(true)] instead, since AFAIU they can depend on global state if $encoding parameter isn't passed. In this case, mb_internal_encoding() will be used, which can depend on the global state. Could you please double-check?

function mb_str_pad(string $string, int $length, string $pad_string = " ", int $pad_type = STR_PAD_RIGHT, ?string $encoding = null): string {}

/**
* @since 8.4
*/
#[Pure]
function mb_ucfirst(string $string, ?string $encoding = null): string {}

/**
* @since 8.4
*/
#[Pure]
function mb_lcfirst(string $string, ?string $encoding = null): string {}

/**
* @since 8.4
*/
#[Pure]
function mb_trim(string $string, ?string $characters = null, ?string $encoding = null): string {}

/**
* @since 8.4
*/
#[Pure]
function mb_ltrim(string $string, ?string $characters = null, ?string $encoding = null): string {}

/**
* @since 8.4
*/
#[Pure]
function mb_rtrim(string $string, ?string $characters = null, ?string $encoding = null): string {}

/**
Expand Down