Skip to content

update: cocoapods import and links #4782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Conversation

danil-pavlov
Copy link
Contributor

@danil-pavlov danil-pavlov commented Mar 31, 2025

This PR fixes the import error (KT-75116), makes option lists in code samples consistent, and adds links between configuration sections (KT-75114)

@danil-pavlov danil-pavlov requested a review from a team as a code owner March 31, 2025 13:00
@danil-pavlov danil-pavlov requested a review from zamulla March 31, 2025 15:40
Copy link
Contributor

@zamulla zamulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question to consider.

2. Check the framework name inside the module, for example `SDWebImageMapKit {}`. If the framework name doesn't match the Pod
name, specify it explicitly:
2. Check the framework name inside the module, for example `SDWebImageMapKit {}`. If the framework name doesn't match
the Pod name, specify it explicitly:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not about the PR changes, but I have trouble understanding what needs to be done here. If the framework name doesn't match the Pod name, what should I specify as moduleName?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Pods are distributed as frameworks, so in some sense, the terms are interchangeable. I'm expanding this section in another PR and mention that as well

@danil-pavlov danil-pavlov merged commit 07819a0 into master Apr 9, 2025
4 checks passed
@danil-pavlov danil-pavlov deleted the cocoapods-issues-first branch April 9, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants