-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Kotlin/JS: Fix typo in docs related to running Kotlin/JS project in NodeJS environment #4760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! @seclerp |
@seclerp, thank you so much for noticing and fixing the typo 🙏 |
Sure! Seems like I made the wrong assumption based on the screenshot that I found below. In Gradle tool window on the right the task is clearly Also, I found one another place with the typo. I'm a bit confused by the whole "run task" section of "Set up a Kotlin/JS project" page, as it refer to some non-existent "aliases". Is it an artifact from the ancient times?
|
Thank you for the updates. |
I haven't figured out how to add the updated screenshots to @seclerp branch, so I've just created another branch for it: https://github.com/JetBrains/kotlin-web-site/pull/4790/files |
e9b65e3
to
7e30cc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM! Thanks for the clarification (:
Hi folks, I suppose
:jsBrowserDevelopmentRun
is not the correct Gradle task name to be used with the NodeJS build target. From the context of the section, I made an assumption that calling:run
is the right thing to do :)