Clarify JS code inlining capabilities #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
Hi! @lppedd |
|
@lppedd thank you so much for the clarification 🙏 |
JSMonk
approved these changes
Mar 31, 2025
AlejandraPedroza
requested changes
Apr 1, 2025
|
@AlejandraPedroza all done. Thanks! |
AlejandraPedroza
approved these changes
Apr 2, 2025
AlejandraPedroza
force-pushed
the
docs/js-inline
branch
from
1b89739 to
bfc9150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time K/JS users make the wrong assumption that the
js()function is able to accept any JS code.However, the truth is the K/JS compiler uses a modified version of the ES3-compliant Rhino library (1.5R3).
This PR clarifies this point, without being explicit about the version of EcmaScript that is supported.