Skip to content

upd: resources in androidLibrary #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

Conversation

ElviraMustafina
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@zamulla zamulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, but I'd like to clarify the intro.

@@ -79,6 +79,19 @@ compose.resources {
```
{initial-collapse-state="collapsed" collapsible="true" collapsed-title="directoryProvider = tasks.register<DownloadRemoteFiles>"}

### Resources in the `androidLibrary` target

Starting with the Android Gradle plugin version 8.8.0, you can use generated assets in the `androidLibrary` target.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually not sure what "generated assets" refers to. Who generates them, at which point? From context it seems that "generated assets" and "multiplatform resources" are the same, which doesn't sound right to me.

Also, if this is an experimental feature, I'd use the "Experimental" label.

@ElviraMustafina ElviraMustafina requested a review from zamulla April 14, 2025 11:31
Copy link
Collaborator

@zamulla zamulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now I get it :)

@ElviraMustafina ElviraMustafina merged commit be8f002 into master Apr 14, 2025
@ElviraMustafina ElviraMustafina deleted the CMP-7824-agp-resources branch April 14, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants