update: runOnIdle() no longer calls waitForIdle() after action #323
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
approved these changes
Mar 21, 2025
ElviraMustafina
requested changes
Mar 21, 2025
Comment on lines
79
to
80
| If your tests rely on that extra `waitForIdle()` call after the `runOnIdle()` action, | ||
| add that call yourself as needed when updating tests for Compose Multiplatform %composeEapVersion%. |
There was a problem hiding this comment.
Suggested change
| If your tests rely on that extra `waitForIdle()` call after the `runOnIdle()` action, | |
| add that call yourself as needed when updating tests for Compose Multiplatform %composeEapVersion%. | |
| If your tests rely on that extra `waitForIdle()` call after the `runOnIdle()` action, | |
| you will need to add that call manually when updating tests for Compose Multiplatform %composeEapVersion%. |
There was a problem hiding this comment.
Not sure about "manually", but I think I rephrased this to solve what you're pointing out.
Co-authored-by: ElviraMustafina <57905309+ElviraMustafina@users.noreply.github.com>
…r-with-Android' into CMP-7822-align-runOnIdle-behavior-with-Android
ElviraMustafina
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this PR: JetBrains/compose-multiplatform-core#1601