Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: adding AS shared module functionality #312

Merged
merged 14 commits into from
Mar 18, 2025
Merged

Conversation

zamulla
Copy link
Collaborator

@zamulla zamulla commented Mar 4, 2025

The "Make your Android app multiplatform" tutorial needs to show creating of a shared module. When it was first published, that was handled by the JetBrains KMP plugin. Then the KMP plugin removed this functionality to make space for the embedded Android Studio wizard, but the wizard was not ready yet, so we wrote instructions on making a shared module manually. Now there's a stable Android Studio (Meerkat) with the shared module wizard, so we're adding the instructions to generate a shared module back.

@zamulla zamulla requested a review from a team as a code owner March 4, 2025 14:09
@zamulla zamulla changed the title update: first pass of adding AS shared module functionality update: adding AS shared module functionality Mar 5, 2025
Copy link
Collaborator

@ElviraMustafina ElviraMustafina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendous job! So far, I've reviewed it as a user

Copy link
Collaborator

@ElviraMustafina ElviraMustafina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few minor suggestions. Overall, LGTM!

@zamulla zamulla merged commit d186880 into master Mar 18, 2025
@zamulla zamulla deleted the meerkat-shared-module branch March 18, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants