Skip to content

origin/radio_button_vika #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

origin/radio_button_vika #1412

wants to merge 6 commits into from

Conversation

WildSeaTurtle
Copy link

No description provided.

Replaced old radio button images with updated versions, adding light and dark mode variants for clarity and consistency. Older assets were moved to a dedicated "old" folder for archival purposes. This improves structure and supports a more modern visual design.
Updated phrasing to improve clarity and consistency, emphasizing when to use checkboxes for two opposing choices. No functional or structural changes were made.
@WildSeaTurtle WildSeaTurtle self-assigned this Jan 2, 2025
Copy link
Collaborator

@eldar-jetbrains eldar-jetbrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is complete, thanks for the updated topic!

@@ -89,19 +107,22 @@ Use the imperative form of verbs.

Do not use negation in labels as it complicates understanding.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Possibly add examples for each rule here with correct incorrect usages to help people better understand the rules
  2. Add bullets to the bullet list

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be a bullet list according to how we write articles now. See how the same section is structured in the Button article

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think if I add all the wrong things in one image? I think it’s quite possible.

<td><img src="07_How_to_use.png" alt="An example of a label spanning two lines." width="378"/></td>
<td><p>If a label is long, split it into two lines. Avoid labels that take more than two lines. See recommendations on writing concise labels below.</p></td>
</tr>
</table>

To implement this, use HTML formatting:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a collapsible "Implementation" chapter


Make labels short and intelligible — see [Writing short and clear text](writing_short.md).

### Group label

![](grouplabel.png){width=267}
![](09_How_to_use.png){width=706}

Always start a radio button group with a group label. It explains what the options are for.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace the content in Sizes and placement chapter into this one: https://plugins.jetbrains.com/docs/intellij/layout.html#checkboxes-and-radio-buttons as "Follow the layout of /checkboxes and radio-buttons/(anchor-link)

@@ -89,19 +107,22 @@ Use the imperative form of verbs.

Do not use negation in labels as it complicates understanding.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be a bullet list according to how we write articles now. See how the same section is structured in the Button article

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants