Notification balloon #1406
Open
Notification balloon #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,131 +12,174 @@ | |||
|
|
|||
| </tldr> | |||
|
|
|||
| Balloon notifications inform users of the events or system states related to a project or IDE. | |||
| Notifications balloons inform users of the events or system states related to a project or IDE. | |||
There was a problem hiding this comment.
I suppose it should be 'Notification balloons' without an s
|
|
||
| ### Show result of an action without context | ||
|
|
||
| Use a timeline notification when an action was called from the context already closed, like a dialog or a popup. |
There was a problem hiding this comment.
I would correct the sentence here "…was called from A context THAT HAS already closed…"
|
|
||
| {width=389} | ||
| When possible, use a plugin or functionality icon instead of the info icon. This helps identifing the source of the notification quicker. |
There was a problem hiding this comment.
Should the icon names be styled with 'control'…'/control'?
|
|
||
| {width=389} | ||
| When possible, use a plugin or functionality icon instead of the info icon. This helps identifing the source of the notification quicker. |
There was a problem hiding this comment.
Can we add a title here as well?
Also, I noticed there is a balloon with an emoji for the PhpStorm discount, but no indication on when to use emoji or other icons? Not sure if it's necessary here but an information about them would definitely eliminate some corner cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.