built-in-button #1389
Merged
built-in-button #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Light and dark mode screenshots show different states.
Is it expected?
| @@ -350,7 +350,7 @@ | |||
| </table> | |||
| </chapter> | |||
| <chapter title="Cancel" id="cancel"> | |||
| <table style="none" column-width="fixed"> | |||
| <table style="none" border="false" column-width="fixed"> | |||
There was a problem hiding this comment.
Could you please stick to the same order in elements? It will be easier to scan if any edits are needed.
I mean that the border attribute in lines 316, 335, 389 are last, but in 353 and 416 are not last.
|
I tried to test it locally, and borders are still present. I updated the |
MariannaKononenko
requested review from
eldar-jetbrains and
WildSeaTurtle
and removed request for
eldar-jetbrains and
WildSeaTurtle
MariannaKononenko
requested review from
OlyaB
and removed request for
eldar-jetbrains
OlyaB
requested changes
Jan 22, 2025
| <table style="none" border="false"> | ||
| <tr> | ||
| <td><format color="369650" style="bold">Correct</format> | ||
| <img src="built_in_button_browse_correct.png" alt="Browse button" width="378"/></td> |
There was a problem hiding this comment.
In the correct example, possibly add a second field with the "list" icon? It would work as a correct example for the button with "..." in the incorrect example
OlyaB
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.