Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose HTML: add an AttrsScope<*>.attr extension function with a Boolean parameter #5178

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Compose HTML: add an AttrsScope<*>.attr extension function with a Boolean parameter #5178

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ca21dc
Add an `AttrsScope<*>.attr` extension function with a `Boolean` param…
ShreckYe Dec 9, 2024
cf307ec
Convert the `AttrsScope<*>.attr` extension function into the function…
ShreckYe Dec 11, 2024
0648545
Add a `booleanAttributeTest` in `AttributesTests` as requested by @eymar
ShreckYe Dec 11, 2024
07db07f
Reformat AttributesTests.kt BTW
ShreckYe Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions html/core/src/jsMain/kotlin/org/jetbrains/compose/web/attributes/AttrsScope.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,3 +246,10 @@ open class AttrsScopeBuilder<TElement : Element>(
private val setClassList: (HTMLElement, Array<out String>) -> Unit = { e, classList ->
e.classList.add(*classList)
}

/**
* Adds a boolean attribute.
* @see AttrsScope.attr
*/
fun AttrsScope<*>.attr(attr: String, value: Boolean = true) =
attr(attr, value.toString())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason making it an extension function?
What do you think about adding this function to the AttrsScope itself?

Would you like to add a test for this new function in AttributesTests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replying. Adding it as a member function looks good to me too. And sure I'd love to add some tests for this.