Multiplatform ImageViewer desktop camera support #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevSrSouza
commented
Mar 22, 2023
| @@ -30,7 +30,14 @@ compose.desktop { | |||
|
|
|||
| val iconsRoot = project.file("../common/src/desktopMain/resources/images") | |||
| macOS { | |||
| iconFile.set(iconsRoot.resolve("icon-mac.icns")) | |||
| //iconFile.set(iconsRoot.resolve("icon-mac.icns")) does not exist | |||
There was a problem hiding this comment.
This was required because it could not find this file.
| @@ -15,5 +15,6 @@ allprojects { | |||
| mavenCentral() | |||
| maven("https://maven.pkg.jetbrains.space/public/p/compose/dev") | |||
| mavenLocal() | |||
| maven("https://jitpack.io") | |||
There was a problem hiding this comment.
We can't add jitpack dependencies because of potential security risks.
Also, we can't add this dependency as a jar, because it is not convenient.
|
This is now available in maven central. Any update? @DevSrSouza |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone correct branch:
git clone -b feat/imageviewer-desktop-camera https://github.com/DevSrSouza/compose-jb.gitThis Pull Request adds support for Camera in Desktop app by using webcam-capture library and converting it RGB ByteArray to Compose/Skiko ARGB to display the image capture as Compose ImageBitmap.
For running the application in MacOS, the apps requires camera permission, so I had to add a
runtime-entitlements.plistwithcom.apple.security.device.cameraand infoPlist entryNSCameraUsageDescription.How to test on MacOS:
./gradlew :desktopApp:createDistributableopen desktopApp/build/compose/binaries/main/app/ImageViewer.appScreen.Recording.2023-03-21.at.21.10.21.mp4