Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added viewport units (lvw,dvw,svw,lvh,dvh,svh) #2764

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added viewport units (lvw,dvw,svw,lvh,dvh,svh) #2764

wants to merge 1 commit into from

Conversation

andylamax
Copy link

No description provided.

@igordmn igordmn requested a review from eymar February 23, 2023 00:51
@eymar
Copy link
Member

eymar commented Feb 24, 2023

Thank you!
Could you please cover the new units in the tests https://github.com/JetBrains/compose-jb/blob/master/web/core/src/jsTest/kotlin/CSSUnitApiTests.kt similar to other units?

@eymar eymar added wait for reply Further information is requested web labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eymar eymar Awaiting requested review from eymar

Assignees
No one assigned
Labels
wait for reply Further information is requested web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andylamax @eymar