App API prototype #1770
Draft
App API prototype #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeselovAlex
reviewed
Feb 3, 2022
| expect fun KAppScope.Frame(content: @Composable () -> Unit) | ||
|
|
||
| // Complex multi-frame application | ||
| fun kapp(name: String = "application", title: String = "Compose Application", content: @Composable KAppScope.() -> Unit) { |
There was a problem hiding this comment.
Does name mean application name, and title mean window title? In this case I think it is reasonable to:
- Remove default argument for name, let's make it mandatory
- Make title a property in some WindowScope, with initial value set to application name
- simpleKapp callback should be in WindowScope, and app callback in some window management (router?) scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.