forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 102
Fix text context menu interaction on Popups and Dialogs #2434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ASalavei
merged 15 commits into
jb-main
from
andrei.salavei/fix-context-menu-interaction-on-popups
Oct 9, 2025
Merged
Fix text context menu interaction on Popups and Dialogs #2434
ASalavei
merged 15 commits into
jb-main
from
andrei.salavei/fix-context-menu-interaction-on-popups
Oct 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
reviewed
Oct 8, 2025
...ose/ui/ui/src/uikitInstrumentedTest/kotlin/androidx/compose/ui/test/AccessibilityTestNode.kt
Show resolved
Hide resolved
igordmn
reviewed
Oct 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but needs a review and approval from an iOS developer
svastven
approved these changes
Oct 8, 2025
mazunin-v-jb
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
hitTest
method to handle touches for Compose view overlays in Popups and Dialogs.Fixes: https://youtrack.jetbrains.com/issue/CMP-8999/Paste-Cut-Copy-Select-all-...-not-clickable-on-iOS-in-dialogs
Fixes: https://youtrack.jetbrains.com/issue/CMP-8537/Fix-toolbar-tests
Release Notes
Fixes - iOS
Popup
s andDialog
s