Fix platformSpecificTextInputSession passing a constant untransformedText to the IME
#1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the initial `untransformedText` TextEditorState into SkikoPlatformTextInputMethodRequest, without ever updating it.
m-sasha
force-pushed
the
m-sasha/update-untransformed-textfield-state
branch
from
d200787 to
3081823
Compare
ASalavei
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
PlatformTextInputSession.platformSpecificTextInputSessionputting the initialuntransformedTextTextEditorState into SkikoPlatformTextInputMethodRequest, without ever updating it.Instead pass a
TextEditorStatewhich delegates to the currentTransformedTextFieldState.untransformedText.This fixes (again) accented character input via long-press on macOS. Probably fixes other bugs too, as it's quite a serious issue to have the IME never receive text state updates.
Testing
This should be tested by QA
Release Notes
Fixes - Desktop