Instrumented tests for iOS #1786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # settings.gradle
|
Added "CI change: https://jetbrains.team/p/ui/reviews/23/files" to the description |
MatkovIvan
reviewed
Apr 3, 2025
compose/ui/ui-xctest/build.gradle
Outdated
There was a problem hiding this comment.
Why is it a part of compose/ui?
There was a problem hiding this comment.
For now the module provides functionality to convert Kotlin tests to the XCTests and support for native UI touches simulation. Both are used by instrumented tests only. It looks like it's the best location for now. Anyway, any proposals are welcomed!
If it will be necessary in the future, we can split this module in 2, but currently I don't see good reasons for this.
There was a problem hiding this comment.
Sounds good. Moved.
Anyway, for now I don't want to split the module into two.
buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring and launch instrumented tests from the compose-multiplatform. Some tests where ignored to be fixed later.
Tests structure:
:compose:ui:ui-xctestproject contains logic of converting Kotlin tests to XCTests, also implement touches simulation (CMPTestUtils).compose/ui/ui/src/uikitInstrumentedTestcontains Kotlin tests that are wrapped into the native iOS framework with XCTests API.compose/ui/ui/src/uikitInstrumentedTest/launchercontains xcode project that launches XCTests inside UIApplication environment on iOS Simulator (tests are running with xcodebuild command).CI change: https://jetbrains.team/p/ui/reviews/23/files
Fixes: https://youtrack.jetbrains.com/issue/CMP-7394/Move-iOS-Instrumented-tests-into-compose-multiplatform-core-after-switching-to-Kotlin-2.1.0
Release Notes
N/A