Skip to content

docs: add AI Foundations skill guide (NES-1501)#8943

Merged
jaco-brink merged 3 commits intomainfrom
jacobusbrink/nes-1501-set-up-ai-foundations-docs-in-core-for-knowledge-sharing
Apr 1, 2026
Merged

docs: add AI Foundations skill guide (NES-1501)#8943
jaco-brink merged 3 commits intomainfrom
jacobusbrink/nes-1501-set-up-ai-foundations-docs-in-core-for-knowledge-sharing

Conversation

@jaco-brink
Copy link
Copy Markdown
Collaborator

@jaco-brink jaco-brink commented Apr 1, 2026

Summary

  • Single-page guide (docs/ai-foundations.md) documenting all AI skills available in core: review-pr, handle-pr-review, reset-stage
  • Covers prerequisites, Cursor skills, Claude Code commands, convention rules, and troubleshooting
  • Added README section linking to the guide
  • Maintenance handoff doc — one file an engineer can read in 5 minutes

Test plan

  • Verify docs/ai-foundations.md renders correctly on GitHub
  • Verify README.md link resolves to the doc
  • Confirm no references to future roadmap or "request new skills" — this is maintenance-mode documentation

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added an "AI-Assisted Engineering" section and a detailed "AI Foundations" guide describing built-in AI skills for PR workflows (review, handle-review, reset-stage), prerequisites and usage modes, triage categories, dry-run vs apply behavior, CLI/terminal command mappings, and extended troubleshooting guidance.

Single-page guide for engineers to discover and use AI skills
(review-pr, handle-pr-review, reset-stage). Documents prerequisites,
Cursor skills, Claude Code commands, convention rules, and
troubleshooting. Added README section linking to the guide.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@linear
Copy link
Copy Markdown

linear bot commented Apr 1, 2026

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cb1a10cd-a2e5-4d98-a542-ed211316aea8

📥 Commits

Reviewing files that changed from the base of the PR and between 4b0aa1d and f42a7a6.

📒 Files selected for processing (1)
  • docs/ai-foundations.md

Walkthrough

Added documentation and README reference for an "AI Foundations" workflow that describes Cursor/Claude-based AI skills for PR review, review-thread handling, and stage-branch reset, including prerequisites, usage modes/flags, and troubleshooting.

Changes

Cohort / File(s) Summary
README update
README.md
Inserted an "AI-Assisted Engineering" section linking to the new AI Foundations guide.
AI Foundations docs
docs/ai-foundations.md
New guide describing prerequisites, three Cursor/Claude Code skills (review-pr, handle-pr-review, reset-stage), modes/flags/triage categories, mapping to Claude Code commands, convention rule files, and troubleshooting details.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer (Trigger)
    participant Cursor as Cursor / Claude Code
    participant Local as Local Tooling / Devcontainer
    participant GH as GitHub (GraphQL / PRs)
    participant Slack as Slack (optional via Doppler)
    Dev->>Cursor: Invoke skill (/review-pr, /handle-pr-review, /reset-stage)
    Cursor->>Local: Run skill script in devcontainer
    Local->>GH: Query PRs/threads & post comments / create commits
    GH-->>Local: Return PR data & accept changes
    Local->>Cursor: Report results
    Cursor->>Dev: Post summary comment / feedback
    alt Slack reporting enabled
        Local->>Slack: Send status/summary via Doppler credentials
        Slack-->>Dev: Deliver notification
    end
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs: add AI Foundations skill guide (NES-1501)' directly and specifically describes the main change: adding documentation for the AI Foundations skills guide.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jacobusbrink/nes-1501-set-up-ai-foundations-docs-in-core-for-knowledge-sharing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Fails
🚫 Please assign someone to merge this PR.

Generated by 🚫 dangerJS against f42a7a6

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Apr 1, 2026

View your CI Pipeline Execution ↗ for commit f42a7a6

Command Status Duration Result
nx affected --target=subgraph-check --base=326d... ✅ Succeeded <1s View ↗
nx affected --target=extract-translations --bas... ✅ Succeeded <1s View ↗
nx affected --target=lint --base=326d15524f8019... ✅ Succeeded <1s View ↗
nx affected --target=type-check --base=326d1552... ✅ Succeeded <1s View ↗
nx run-many --target=codegen --all --parallel=3 ✅ Succeeded 2s View ↗
nx run-many --target=prisma-generate --all --pa... ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-01 18:53:22 UTC

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
docs/ai-foundations.md (2)

36-43: Consider adding a safety note about the destructive nature of --apply.

While line 40 notes "(destructive, prompts for confirmation)", consider adding a brief warning that reset-stage --apply will force-push to the stage branch and potentially discard work. This could prevent accidental data loss.

📝 Suggested enhancement
 ### reset-stage flags
 
+> ⚠️ **Warning**: `--apply` performs a destructive reset. It will force-push to stage and discard any uncommitted work on that branch. Always run without `--apply` first to preview changes.
+
 ```bash
 ./tools/scripts/reset-stage.sh           # Dry run (safe, no changes)
 ./tools/scripts/reset-stage.sh --apply   # Actual reset (destructive, prompts for confirmation)
 ./tools/scripts/reset-stage.sh --apply --no-slack  # Reset without Slack notification
</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against the current code and only fix it if needed.

In @docs/ai-foundations.md around lines 36 - 43, Add a clear safety warning to
the reset-stage documentation noting that running ./tools/scripts/reset-stage.sh
--apply will perform a destructive operation (it force-pushes to the stage
branch and can discard unmerged work), that it prompts for confirmation but
should be used with caution, and suggest performing a dry run first or backing
up local changes; reference the script name reset-stage.sh and the --apply and
--no-slack flags so readers know which command is destructive.


</details>

---

`44-54`: **Clarify the scope of Claude Code availability.**

Line 46 states "The same skills are available in Claude Code for terminal-based workflows", but the table only shows `/review-pr` and `/handle-pr-review`. Is `/reset-stage` intentionally excluded? If so, briefly explain why (e.g., "reset-stage is a shell script and should be run directly").



<details>
<summary>📝 Suggested clarification</summary>

If reset-stage is intentionally excluded:

```diff
 ## Claude Code Commands
 
-The same skills are available in Claude Code for terminal-based workflows.
+PR-related skills are available in Claude Code for terminal-based workflows. The reset-stage skill is a standalone script (`tools/scripts/reset-stage.sh`) and should be run directly in the terminal.
 
 | Command | Equivalent Cursor skill |
 |---------|------------------------|
 | `/review-pr` | review-pr |
 | `/handle-pr-review` | handle-pr-review |

Alternatively, if it should be included, add it to the table.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/ai-foundations.md` around lines 44 - 54, The docs claim "The same skills
are available in Claude Code" but the table only lists `/review-pr` and
`/handle-pr-review` and omits `/reset-stage`; clarify whether `/reset-stage` is
intentionally excluded or should be listed: if excluded, add a short
parenthetical note explaining why (e.g., "`/reset-stage` is a shell script and
must be run directly"), otherwise add `/reset-stage` to the table as an
additional row mapping to reset-stage so the table accurately reflects available
Claude Code commands.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@docs/ai-foundations.md`:
- Around line 36-43: Add a clear safety warning to the reset-stage documentation
noting that running ./tools/scripts/reset-stage.sh --apply will perform a
destructive operation (it force-pushes to the stage branch and can discard
unmerged work), that it prompts for confirmation but should be used with
caution, and suggest performing a dry run first or backing up local changes;
reference the script name reset-stage.sh and the --apply and --no-slack flags so
readers know which command is destructive.
- Around line 44-54: The docs claim "The same skills are available in Claude
Code" but the table only lists `/review-pr` and `/handle-pr-review` and omits
`/reset-stage`; clarify whether `/reset-stage` is intentionally excluded or
should be listed: if excluded, add a short parenthetical note explaining why
(e.g., "`/reset-stage` is a shell script and must be run directly"), otherwise
add `/reset-stage` to the table as an additional row mapping to reset-stage so
the table accurately reflects available Claude Code commands.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 135ce798-553b-49ba-a635-9d2b5ba83b56

📥 Commits

Reviewing files that changed from the base of the PR and between 326d155 and 426dc46.

📒 Files selected for processing (2)
  • README.md
  • docs/ai-foundations.md

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/ai-foundations.md`:
- Line 3: Update the sentence "AI skills that automate common engineering tasks
in core. These run inside Cursor and Claude Code — no external services, no cost
beyond your existing tooling." to clarify that core skill execution runs locally
in Cursor/Claude Code but some workflows require external integrations;
explicitly call out the exceptions such as GitHub CLI access ('gh'), Doppler
authentication, and Slack notification flow so readers don’t assume zero
external configuration is ever needed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 29750e74-36d7-4742-bb72-b658cfc6c2e3

📥 Commits

Reviewing files that changed from the base of the PR and between 426dc46 and 4b0aa1d.

📒 Files selected for processing (1)
  • docs/ai-foundations.md

Address review feedback:
- Reword intro to acknowledge gh CLI and Doppler dependencies
  instead of claiming "no external services"
- Clarify that only review skills (not reset-stage) have Claude
  Code command equivalents

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@jaco-brink
Copy link
Copy Markdown
Collaborator Author

Review feedback addressed (f42a7a6)

Fixed (adjusted):

  • docs/ai-foundations.md:3 — Reworded intro to acknowledge gh CLI and Doppler dependencies instead of claiming "no external services". Used concise wording rather than CodeRabbit's verbose suggestion.
  • docs/ai-foundations.md:46 — Clarified that only the review skills (not reset-stage) have Claude Code command equivalents. Changed "The same skills" to "The review skills".

@jaco-brink jaco-brink merged commit 97c5d50 into main Apr 1, 2026
18 of 21 checks passed
@jaco-brink jaco-brink deleted the jacobusbrink/nes-1501-set-up-ai-foundations-docs-in-core-for-knowledge-sharing branch April 1, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant