Conversation
… (NES-1492) The Google Account dropdown in the Sheets Sync Dialog was showing all team members' Google integrations. Now it filters by the current user's ID so only their own connected accounts appear. https://claude.ai/code/session_01EtYKMXcLEPLCFWaNsqw4FK
|
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe dialog now reads the authenticated user via Changes
Sequence Diagram(s)sequenceDiagram
participant Dialog as GoogleSheetsSyncDialog
participant Auth as useAuth
participant Data as integrationsData (props)
participant UI as Dropdown
Dialog->>Auth: call useAuth()
Auth-->>Dialog: return user (id or null)
Dialog->>Data: read integrationsData.integrations
Dialog-->>Dialog: filter integrations where integration.user.id == user.id
Dialog->>UI: render dropdown options from filtered integrations
UI-->>Dialog: user selects integration (or sees only placeholder)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 7b4e9f2
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@apps/journeys-admin/src/components/JourneyVisitorsList/FilterDrawer/GoogleSheetsSyncDialog/GoogleSheetsSyncDialog.tsx`:
- Around line 171-175: The ownership filter for myGoogleIntegrations can pass
when both integration.user?.id and user?.id are undefined; update the filter in
the myGoogleIntegrations computation to require concrete IDs before comparing by
first checking that both integration.user?.id and user?.id are non-null/defined
and then comparing equality (e.g., ensure integration.user?.id !== undefined &&
user?.id !== undefined && integration.user.id === user.id) so integrations
without an owner are excluded when auth state is unresolved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a46d6933-bdff-498d-8f24-b01fec20b9b2
📒 Files selected for processing (3)
apps/journeys-admin/src/components/JourneyVisitorsList/FilterDrawer/GoogleSheetsSyncDialog/GoogleSheetsSyncDialog.spec.tsxapps/journeys-admin/src/components/JourneyVisitorsList/FilterDrawer/GoogleSheetsSyncDialog/GoogleSheetsSyncDialog.tsxdocs/nes-1492-fix-google-sync-dropdown.md
...omponents/JourneyVisitorsList/FilterDrawer/GoogleSheetsSyncDialog/GoogleSheetsSyncDialog.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
The latest updates on your projects.
|
… (NES-1492) - Use type predicate to properly narrow integration union type (fixes TS2339) - Fix import path to __generated__/GetIntegration (was missing a ../ level) - Guard against undefined === undefined when user or integration owner is null - Rename myGoogleIntegrations to currentUserIntegrations for clarity - Simplify renderValue by removing redundant __typename check - Add test for unauthenticated user edge case - Remove unnecessary implementation plan doc Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
jianwei1
force-pushed
the
jianweichong/nes-1492-google-sync-dropdown-shows-another-managers-gmail-account
branch
from
89b6c97 to
d1b3cbd
Compare
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
…hows-another-managers-gmail-account
mikeallisonJS
approved these changes
Mar 31, 2026
…hows-another-managers-gmail-account
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useAuth()to only display integrations belonging to the current userTest plan
https://claude.ai/code/session_01EtYKMXcLEPLCFWaNsqw4FK
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Localization