Open
Conversation
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
WalkthroughA new QA Checklist Generator skill descriptor is added that defines a workflow for generating acceptance criteria and regression testing checklists from branch changes and Linear issue data, including steps for analysis, generation, user review, and Linear ticket updates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit f487b33
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/skills/qa-checklist/SKILL.md:
- Around line 41-49: Modify the "Update the Linear ticket" step to require an
exact match for the "Acceptance Criteria" heading before replacing content:
search the description for the exact string "Acceptance Criteria" as a distinct
heading and only perform the in-place replacement when that exact section is
found; if no exact match or multiple ambiguous matches exist, do not edit and
instead prompt the user for clarification or request permission to create a new
checklist section, showing the proposed checklist for approval before making any
changes.
- Around line 26-41: The document currently says to generate two checklist
sections (Acceptance Criteria and Regression Testing) but step 6 only instructs
replacing the Acceptance Criteria in Linear, creating ambiguity about what
happens to Regression Testing; update the SKILL.md steps so step 6 explicitly
states whether to (A) replace or create both the "Acceptance Criteria" and
"Regression Testing" sections in the Linear issue description with the generated
content, or (B) replace only "Acceptance Criteria" and keep "Regression Testing"
as a user-visible output that is not persisted to Linear—make this contract
explicit in the "Generate the checklist" (step 4), "Show the checklist" (step
5), and "Update the Linear ticket" (step 6) instructions so agents know exactly
which sections to persist.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 4b0f672e-fe36-43be-8c3b-aa43a992a06b
📒 Files selected for processing (1)
.claude/skills/qa-checklist/SKILL.md
Comment on lines
+26
to
+41
| 4. **Generate the checklist**: Write a checklist with two sections: | ||
|
|
||
| **Acceptance Criteria** — What the feature should do (based on the issue requirements): | ||
| - Written as checkbox items (`- [ ]`) | ||
| - Non-technical language a QA tester can follow | ||
| - Focused on observable behavior, not implementation details | ||
|
|
||
| **Regression Testing** — What else should be manually verified to ensure nothing broke: | ||
| - Grouped by user flow or page | ||
| - Written as checkbox items (`- [ ]`) | ||
| - Include any special testing notes (e.g., timing, environment requirements) | ||
| - Cover all entry points where shared/modified code is used | ||
|
|
||
| 5. **Show the checklist to the user** for review before updating Linear. | ||
|
|
||
| 6. **Update the Linear ticket**: Once approved, replace the Acceptance Criteria section in the issue description with the new checklist. Keep the rest of the description unchanged. |
Contributor
There was a problem hiding this comment.
Clarify where the Regression Testing section is persisted.
Step 4 generates two sections, but Line 41 only tells the agent to replace Acceptance Criteria. As written, the Regression Testing checklist is either dropped or forced into the wrong section when the Linear update happens.
Please make the update contract explicit, e.g. replace/create both sections in the description, or update one section and leave the other as user-only output.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/skills/qa-checklist/SKILL.md around lines 26 - 41, The document
currently says to generate two checklist sections (Acceptance Criteria and
Regression Testing) but step 6 only instructs replacing the Acceptance Criteria
in Linear, creating ambiguity about what happens to Regression Testing; update
the SKILL.md steps so step 6 explicitly states whether to (A) replace or create
both the "Acceptance Criteria" and "Regression Testing" sections in the Linear
issue description with the generated content, or (B) replace only "Acceptance
Criteria" and keep "Regression Testing" as a user-visible output that is not
persisted to Linear—make this contract explicit in the "Generate the checklist"
(step 4), "Show the checklist" (step 5), and "Update the Linear ticket" (step 6)
instructions so agents know exactly which sections to persist.
Comment on lines
+41
to
+49
| 6. **Update the Linear ticket**: Once approved, replace the Acceptance Criteria section in the issue description with the new checklist. Keep the rest of the description unchanged. | ||
|
|
||
| ## Important | ||
|
|
||
| - Write for a QA team — avoid technical jargon, code references, and implementation details. | ||
| - Use checkbox format (`- [ ]`) for all items so they can be checked off. | ||
| - Do NOT add progress summaries or implementation notes to the ticket. | ||
| - Do NOT add the checklist as a comment — update the description directly. | ||
| - Always show the checklist to the user for review before updating Linear. |
Contributor
There was a problem hiding this comment.
Add a safe fallback when the ticket lacks a matching section.
Updating the description directly is risky without defining how to find the existing Acceptance Criteria block. If the heading is missing or named differently, the skill can overwrite unrelated parts of the Linear description instead of preserving them.
Please require an exact section match and fall back to asking the user before editing when the section cannot be identified unambiguously.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/skills/qa-checklist/SKILL.md around lines 41 - 49, Modify the
"Update the Linear ticket" step to require an exact match for the "Acceptance
Criteria" heading before replacing content: search the description for the exact
string "Acceptance Criteria" as a distinct heading and only perform the in-place
replacement when that exact section is found; if no exact match or multiple
ambiguous matches exist, do not edit and instead prompt the user for
clarification or request permission to create a new checklist section, showing
the proposed checklist for approval before making any changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/qa-checklistClaude Code skill that generates QA acceptance criteria and regression testing checklistsLinear
NES-1429
🤖 Generated with Claude Code
Summary by CodeRabbit