Skip to content

refactor: simplify GoogleSheetsSyncDialog#8821

Draft
edmonday wants to merge 43 commits intomainfrom
edmondshen/nes-1416-frontend-refactor-googlesheetssyncdialog-for-readability-and
Draft

refactor: simplify GoogleSheetsSyncDialog#8821
edmonday wants to merge 43 commits intomainfrom
edmondshen/nes-1416-frontend-refactor-googlesheetssyncdialog-for-readability-and

Conversation

@edmonday
Copy link
Copy Markdown
Contributor

@edmonday edmonday commented Mar 9, 2026

No description provided.

edmonday and others added 30 commits March 2, 2026 04:04
Create ScreenWrapper component with responsive title/subtitle and
migrate all 6 customization screens to use it. Fixes MediaScreen
using wrong Typography variants and broken color prop.

Refs: NES-1364

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Eliminate the headerSx prop from DoneScreen, LanguageScreen, LinksScreen, and ScreenWrapper components to streamline the code. Update TextScreen to maintain consistent mobileSubtitle formatting.
Refs: NES-1295

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Refs: NES-1297

Co-Authored-By: Claude Opus 4.6 <[email protected]>
…ialog

- Added mutation for creating Google integration.
- Implemented OAuth code handling directly in the sync dialog.
- Updated routing logic to support new integration flow.
- Enhanced user feedback with success/error notifications.

Refs: NES-1298
- Integrated user authentication check before handling OAuth code exchange.
- Updated effect dependencies to include user.clientInitialized for better synchronization.

Refs: NES-1298
…-journey' into edmondshen/nes-1297-google-sheets-sync-for-a-journey
…-journey' into edmondshen/nes-1297-google-sheets-sync-for-a-journey
…edmondshen/nes-1295-toggle-email-notifications-on-for-a-journey
…edmondshen/nes-1295-toggle-email-notifications-on-for-a-journey
@edmonday edmonday self-assigned this Mar 9, 2026
@linear
Copy link
Copy Markdown

linear bot commented Mar 9, 2026

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 9, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6cffe0fe-68a1-433f-b8d9-feba40d159bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edmondshen/nes-1416-frontend-refactor-googlesheetssyncdialog-for-readability-and

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

Fails
🚫 Please request a reviewer for this PR.
Warnings
⚠️ ❗ Big PR (2707 changes)

(change count - 2707): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against 15b617b

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

Fails
🚫 Please request a reviewer for this PR.
Warnings
⚠️ ❗ Big PR (2707 changes)

(change count - 2707): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against 15b617b

Base automatically changed from edmondshen/nes-1297-google-sheets-sync-for-a-journey to main March 17, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant