Repository navigation
Fix manga removal and library deletion regressions - #120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local manga imports had no removal action or API route. This adds confirmed removal in Library → Manga and
DELETE /api/library/manga/{id}, preserving the file on disk and unlinking wanted entries and tags atomically.Also fixes library removal failures exposed by the regression tests: deleting the last item on a page now returns to an existing page, delayed responses cannot overwrite the current category, and pending removals disable repeat clicks. Audiobookshelf errors are returned instead of reporting a successful deletion. Typed routes reject IDs from other media categories. Kavita series remain managed in Kavita; an explicit
source=localselects a local manga ID when Kavita is configured, preventing provider/local ID collisions.Regression coverage includes all three library categories on desktop/mobile, cancellation, failed deletion and retry, filtered/last-page results, persistence after reload, a real CBZ import/removal journey, authentication, provider failures, and database rollback. Every browser test now fails on uncaught JavaScript errors. New tests run in the existing CI suite.
Validation:
verify: PASS: 3/3 steps passed, including the React build, Go tests/build, and 64 browser tests (12 new journeys).go test -race ./... -count=1.go test -tags=integration -race ./internal/integration/... -count=1.go vet ./....Closes #119.