Conversation
core-java/src/main/java/eu/ostrzyciel/jelly/core/JellyConstants.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/ostrzyciel/jelly/core/JellyException.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/ostrzyciel/jelly/core/internal/ProtoDecoderImpl.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/ostrzyciel/jelly/core/internal/ProtoDecoderImpl.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/ostrzyciel/jelly/core/internal/ProtoDecoderImpl.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/ostrzyciel/jelly/core/internal/ProtoEncoderImpl.java
Outdated
Show resolved
Hide resolved
db99436 to
48c8eef
Compare
3a4ef02 to
9cf0c90
Compare
core-java/src/main/java/eu/neverblink/jelly/core/JellyConverterFactory.java
Outdated
Show resolved
Hide resolved
ee447a3 to
5842f05
Compare
5842f05 to
70e381c
Compare
Ostrzyciel
left a comment
There was a problem hiding this comment.
partial review, continuing
core-java/src/main/java/eu/neverblink/jelly/core/JellyConverterFactory.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/JellyOptions.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/ProtoDecoderConverter.java
Outdated
Show resolved
Hide resolved
| * Parameters passed to the Jelly encoder. | ||
| * <p> | ||
| * New fields may be added in the future, but always with a default value and in a sequential order. | ||
| * However, it is still recommended to use named arguments when creating this object. |
There was a problem hiding this comment.
This is out of date, I think.
I haven't worked with Java records. Can we add new fields in a backwards-compatible manner? Or would we need explicit constructors for that?
There was a problem hiding this comment.
we need explicit constructors for that
There was a problem hiding this comment.
Then I'm for adding explicit constructors. This will be wordy and awful, I know, but otherwise introducing a new parameter to the constructor would be a breaking change (!!!!) requiring us to bump the version to 4.0.0. That's bad.
There was a problem hiding this comment.
We can use factory methods like you did in scala,
or we can use static Params of(...) in Params (aka "named" constructors) to achieve same effect
core-java/src/main/java/eu/neverblink/jelly/core/ProtoEncoder.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/ProtoEncoder.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/ProtoHandler.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/ProtoHandler.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/ProtoHandler.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/internal/ProtoDecoderImpl.java
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/internal/ProtoDecoderImpl.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/ProtoEncoder.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/RdfHandler.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/RdfHandler.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/RdfHandler.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/RdfProtoDeserializationError.java
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/RdfProtoTranscodingError.java
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/internal/NameDecoderImpl.java
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/internal/ProtoEncoderImpl.java
Outdated
Show resolved
Hide resolved
core-java/src/main/java/eu/neverblink/jelly/core/utils/TripleEncoder.java
Show resolved
Hide resolved
b3cc9db to
15e354e
Compare
This PR adds
core-javaandrdf-protos-javamodules intended to replacecoreandrdf-protos, written in scala to ones written in pure java.This is a part of preparation for
v3.0.0release.Link to repo before breaking changes: v2.10.2
Notable API Changes:
eu.neverblinkis introduced to all new modulesJellyConstants,JellyOptionswithUPPERCASE_NAMINGfor constants replacedConstantsandOptionsJellyConverterFactoryandJellyTranscoderFactoryintroduced to centralise core modules context maintaining.ProtoDecoderchain now depends onProtoHandler<TNode>as a handler of different statement types decoding.ProtoDecodernow does not specify types of Triples and Quads.ProtoEncodernow does not returnIterable<Row>on ingestion, instead aCollection<RdfStreamRow> appendableRowBuffermust be passed through parameters for the purposes of encoded statements collection.