Skip to content

rdf to-jelly: make sure name table has size >=8 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ostrzyciel merged 3 commits into from
Apr 25, 2025
Merged

rdf to-jelly: make sure name table has size >=8 #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4051b89
rdf to-jelly: make sure name table has size >=8
Ostrzyciel Apr 25, 2025
06fd0c1
fix test
Ostrzyciel Apr 25, 2025
532ce07
fix review
Ostrzyciel Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ resolvers +=
"Sonatype OSS Snapshots" at "https://s01.oss.sonatype.org/content/repositories/snapshots"

lazy val jenaV = "5.3.0"
lazy val jellyV = "2.10.2"
lazy val jellyV = "2.10.3"

addCommandAlias("fixAll", "scalafixAll; scalafmtAll")

Expand Down
14 changes: 13 additions & 1 deletion src/test/scala/eu/neverblink/jelly/cli/command/rdf/RdfToJellySpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package eu.neverblink.jelly.cli.command.rdf

import eu.neverblink.jelly.cli.command.helpers.{DataGenHelper, TestFixtureHelper}
import eu.neverblink.jelly.cli.command.rdf.util.RdfFormat
import eu.neverblink.jelly.cli.{ExitException, InvalidArgument, InvalidFormatSpecified}
import eu.neverblink.jelly.cli.*
import eu.ostrzyciel.jelly.convert.jena.riot.JellyLanguage
import eu.ostrzyciel.jelly.core.proto.v1.{LogicalStreamType, RdfStreamFrame}
import eu.ostrzyciel.jelly.core.{IoUtils, JellyOptions}
Expand Down Expand Up @@ -397,6 +397,7 @@ class RdfToJellySpec extends AnyWordSpec with TestFixtureHelper with Matchers:
cause.validFormats should be(RdfToJellyPrint.validFormatsString)
cause.format should be("invalid")
}

"invalid format out of existing is specified" in withFullJenaFile { f =>
val e =
intercept[ExitException] {
Expand All @@ -408,6 +409,7 @@ class RdfToJellySpec extends AnyWordSpec with TestFixtureHelper with Matchers:
cause.validFormats should be(RdfToJellyPrint.validFormatsString)
cause.format should be("jelly")
}

"invalid logical stream type is specified" in withFullJenaFile { f =>
val e =
intercept[ExitException] {
Expand All @@ -419,5 +421,15 @@ class RdfToJellySpec extends AnyWordSpec with TestFixtureHelper with Matchers:
cause.argumentValue should be("test")
e.code should be(1)
}

"name table with size < 8 specified" in withFullJenaFile { f =>
val e = intercept[ExitException] {
RdfToJelly.runTestCommand(List("rdf", "to-jelly", f, "--opt.max-name-table-size=5"))
}
e.cause.get shouldBe a[JellySerializationError]
val cause = e.cause.get.asInstanceOf[JellySerializationError]
cause.message should include("name table size of 5 ")
e.code should be(1)
}
}
}