Merged
Conversation
Collaborator
Author
|
Tested on AOT from github workflow, no warnings here, it must be a local generation issue then. |
Member
Could you specify what warning is this and what Graal version you have? If it appears on a newer version of Graal, then it will eventually appear in CI. It's worth opening an issue to resolve this. |
Collaborator
Author
|
Warning text: native-image --version |
Ostrzyciel
requested changes
Mar 22, 2025
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfFromJelly.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfFromJelly.scala
Outdated
Show resolved
Hide resolved
src/test/scala/eu/neverblink/jelly/cli/command/RdfFromJellySpec.scala
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Tested on AOT and works. Test coverage for methods generally above 80%, most but not every custom exception currently included in test - if needed, more mocks will be added. |
Ostrzyciel
requested changes
Mar 24, 2025
Collaborator
Author
|
Corrected comments, checked AOT/tests, everything still works |
Ostrzyciel
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #25
Adds error handling. Deletes the Fool Around command as well - seems redundant.
Tested on AOT generated locally, but encountered some warnings that were not there when I ran the tests - I'll test it on AOT generated through the github workflow in a minute and let you know.