Merged
Conversation
Previously blank node IDs were reassigned to new ones, drawing from some hashed in-memory pool. This unnecessarily wasted resources (we can keep the original IDs, they are fine for our use case), made a mess in the output, and could potentially lead to OOMs for very large files. This somewhat speeds up the conversion for files that contain blank nodes. For OSM data, I saw ~10% better throughput in converting Turtle to Jelly. It's still not amazingly fast, mostly due to the Turtle parser, but I'm hesitant to mess with it further – we may break something important.
nk2IsHere
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously blank node IDs were reassigned to new ones, drawing from some hashed in-memory pool. This unnecessarily wasted resources (we can keep the original IDs, they are fine for our use case), made a mess in the output, and could potentially lead to OOMs for very large files.
This somewhat speeds up the conversion for files that contain blank nodes. For OSM data, I saw ~10% better throughput in converting Turtle to Jelly.
It's still not amazingly fast, mostly due to the Turtle parser, but I'm hesitant to mess with it further – we may break something important.