GH-93 Allow non streaming output formats in rdf from-jelly#148
Merged
niegrzybkowski merged 12 commits intomainfrom Jul 8, 2025
Merged
Conversation
Ostrzyciel
requested changes
Jul 7, 2025
Member
Ostrzyciel
left a comment
Ostrzyciel
left a comment
There was a problem hiding this comment.
Please also:
- document in command help that the conversion is done frame-by-frame (not for the entire stream by default)
- introduce an option to write the entire stream as one Dataset/Model (one batch)
src/main/scala/eu/neverblink/jelly/cli/util/jena/StreamRdfBatchSink.scala
Outdated
Show resolved
Hide resolved
src/test/scala/eu/neverblink/jelly/cli/command/rdf/RdfFromJellySpec.scala
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/RdfFormat.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/util/jena/StreamRdfBatchSink.scala
Outdated
Show resolved
Hide resolved
Ostrzyciel
requested changes
Jul 8, 2025
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfFromJelly.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfFromJelly.scala
Outdated
Show resolved
Hide resolved
niegrzybkowski
deleted the
GH-93/rdf-from-jelly-allow-non-streaming-output-formats
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93
I add
StreamRdfBatchSinkwhich implementsStreamRDF. The class builds a Jena Model while receiving events, and when finishing, serializes the model into a selected format and streams it out. This is plugged into thefrom-jellycommand with a new formatRdfFormat.Jena.BatchWriteable, and by moving the writer initialization out ofjellyToLangto the call-sites. I add tests for checking graph isomorphism for both rdfxml and jsonld, and remove the test for the non-streaming format error, as there are no longer any non-writeable formats defined.