GH-92: Add "--version" alias to the version command#146
Merged
Ostrzyciel merged 4 commits intomainfrom Jul 4, 2025
Merged
Conversation
Ostrzyciel
reviewed
Jul 3, 2025
Ostrzyciel
requested changes
Jul 3, 2025
Member
Ostrzyciel
left a comment
Ostrzyciel
left a comment
There was a problem hiding this comment.
Please confirm that you tested the built app and it works as intended.
Contributor
Author
|
Yes, I've built the assembly jar and it works as intended. I also added a test. |
Ostrzyciel
requested changes
Jul 4, 2025
Member
Ostrzyciel
left a comment
Ostrzyciel
left a comment
There was a problem hiding this comment.
Please also mark comments that were resolved as "resolved" :) this helps tkdy up the discussion.
src/test/scala/eu/neverblink/jelly/cli/command/VersionSpec.scala
Outdated
Show resolved
Hide resolved
Ostrzyciel
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92.
This does feel quite dirty, since it's a command that pretends to be an option. However, to my knowledge of
caseapp, implementing it as an actual option would require some awkward changes in the code for no real benefit.