rdf validate: fix comparing bnodes in quoted triples#114
Merged
Ostrzyciel merged 1 commit intomainfrom May 9, 2025
Conversation
Closes #113 Added a regression test for that. Also improved the error messages emitted by the validator to point to the exact RDF term that's not matching.
Karolina-Bogacka
approved these changes
May 9, 2025
| OrderedRdfCompare.compare(c1, c3) | ||
| } | ||
| e.getMessage should include("RDF element 1 is different: expected") | ||
| e.getMessage should include("RDF element 1 is different in subject term: expected") |
Collaborator
There was a problem hiding this comment.
one suggestion: maybe add a new exception for this kind of errors instead of just throwing Critical Exception? then you could just compare the exception.msg and skip having to maintain it through strings in OrderedRdfCompare and in these tests
Member
Author
There was a problem hiding this comment.
yeah, would be nice, but I'm too lazy and this works
Ostrzyciel
deleted the
GH-113-rdf-validate-blank-nodes-within-quoted-triples-are-not-compared-correctly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113
Added a regression test for that. Also improved the error messages emitted by the validator to point to the exact RDF term that's not matching.