-
Notifications
You must be signed in to change notification settings - Fork 26
fix(build): prioritize Maven central repository #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
This should greatly reduce the number of 404s seen on clasweb logs. We now have the following numbers of 404 responses, before and after this change: ``` For https://clasweb.jlab.org/.clas12maven: - before change: 166 - after change: 28 For https://clasweb.jlab.org/.jhep/maven: - before change: 165 - after change: 11 ``` I confirmed that the 28 remaining 404s from clas12maven and the 11 from jhep/maven are coming from cases where Maven searches clas12maven first, then finds the dependency on jhep/maven, or vice versa. We may need a repository management solution (Nexus, Artifactory) to stop those.
|
Would generating a list of the repos that change their source host be difficult? |
I'm not sure what you mean by this. The 404 responses is "normal" Maven behavior, unfortunately. It is not possible to tell Maven which repository to prioritize for each dependency. |
|
Let's merge #954 first. |
I mean repos whose source host change when their ordering/prioritization in our config files is changed. |
|
Ah, you mean something that would come from one of our Should we close this? The only "issue" this addresses is reducing the number of 404 responses in the server logs... |
|
Yes, I think we should double check that list of the differences first. |
Maven checks repositories in order, for dependencies. If a "404 not found" is returned, it moves on to the next repository until a dependency is found. Before this PR, Maven central is last in the priority list; this PR puts Maven central first, since most of our dependencies come from there.
This should greatly reduce the number of 404s seen on clasweb logs. We now have the following numbers of 404 responses, before and after this change:
I confirmed that the 28 remaining 404s from clas12maven and the 11 from jhep/maven are coming from cases where Maven searches clas12maven first, then finds the dependency on jhep/maven, or vice versa. We may need a repository management solution (Nexus, Artifactory) to stop those.