-
Notifications
You must be signed in to change notification settings - Fork 26
RGH Recoil TOF geometry and reconstruction #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POM fixes, to be consistent with the current development branch:
Co-authored-by: Christopher Dilks <[email protected]>
|
Great, now it builds and passes most CI tests, except for dependency analysis. We require POMs to specify exactly what dependencies are needed, no more no less. See errors here: https://github.com/JeffersonLab/coatjava/actions/runs/18916433992/job/54001572954?pr=921#step:7:1699 Usually this is straightforward to fix; see other |
|
Thanks. Should I just add "Used undeclared dependencies" to the pom.xml and remove "Unused declared dependencies"? |
Yes, that's usually enough. |
|
Sometimes certain dependencies come through transitively too, so you may need to be a bit more precise with specifying what your code really needs. For example, if A depends on B which depends on C, and your code depends on C, you need to specify C as a dependency, not B (even if both cases lead to successful compilation). |
|
What files should I consider when including dependencies? Is that for import statements in reconstruction/recoiltof/src/main/java/org/jlab/service/recoiltof/RECOILTOFEngine.java? |
The POM file |
|
The java files use "import org.jlab.geom" and "import org.jlab.detector". I used "org.jlab.clas:clas-geometry" and "org.jlab.clas:clas-detector" as dependencies in pom.xml. The compiler says those are unused. What should I change those dependencies to? |
Co-authored-by: Christopher Dilks <[email protected]>
This PR includes the geometry and reconstruction for RGH recoil TOF detector.
The reconstruction follows a similar approach as in ATOF.
Running recon-util with engine org.jlab.service.recoiltof.RECOILTOFEngine produces new hipo banks RECOILTOF::hits and RECOILTOF::clusters.