Skip to content

Conversation

@niwgit
Copy link

@niwgit niwgit commented Oct 29, 2025

This PR includes the geometry and reconstruction for RGH recoil TOF detector.
The reconstruction follows a similar approach as in ATOF.
Running recon-util with engine org.jlab.service.recoiltof.RECOILTOFEngine produces new hipo banks RECOILTOF::hits and RECOILTOF::clusters.

Copy link
Member

@c-dilks c-dilks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POM fixes, to be consistent with the current development branch:

@c-dilks
Copy link
Member

c-dilks commented Oct 29, 2025

Great, now it builds and passes most CI tests, except for dependency analysis. We require POMs to specify exactly what dependencies are needed, no more no less. See errors here: https://github.com/JeffersonLab/coatjava/actions/runs/18916433992/job/54001572954?pr=921#step:7:1699

Usually this is straightforward to fix; see other reconstruction modules' POM files for example dependency XML nodes.

@niwgit
Copy link
Author

niwgit commented Oct 30, 2025

Thanks. Should I just add "Used undeclared dependencies" to the pom.xml and remove "Unused declared dependencies"?

@c-dilks
Copy link
Member

c-dilks commented Oct 30, 2025

Thanks. Should I just add "Used undeclared dependencies" to the pom.xml and remove "Unused declared dependencies"?

Yes, that's usually enough.

@c-dilks
Copy link
Member

c-dilks commented Oct 30, 2025

Sometimes certain dependencies come through transitively too, so you may need to be a bit more precise with specifying what your code really needs. For example, if A depends on B which depends on C, and your code depends on C, you need to specify C as a dependency, not B (even if both cases lead to successful compilation).

@niwgit
Copy link
Author

niwgit commented Oct 30, 2025

What files should I consider when including dependencies? Is that for import statements in reconstruction/recoiltof/src/main/java/org/jlab/service/recoiltof/RECOILTOFEngine.java?

@c-dilks
Copy link
Member

c-dilks commented Oct 30, 2025

What files should I consider when including dependencies? Is that for import statements in reconstruction/recoiltof/src/main/java/org/jlab/service/recoiltof/RECOILTOFEngine.java?

The POM file reconstruction/recoiltof/pom.xml applies to all files within reconstruction/recoiltof/, that is, consider all the imports in all the Java files within that directory.

@niwgit
Copy link
Author

niwgit commented Oct 30, 2025

The java files use "import org.jlab.geom" and "import org.jlab.detector". I used "org.jlab.clas:clas-geometry" and "org.jlab.clas:clas-detector" as dependencies in pom.xml. The compiler says those are unused. What should I change those dependencies to?

Co-authored-by: Christopher Dilks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants