Skip to content

Detector changed hook #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 48 commits into
base: development
Choose a base branch
from
Draft

Detector changed hook #905

wants to merge 48 commits into from

Conversation

@baltzell
Copy link
Collaborator

@baltzell baltzell commented Oct 23, 2025

No description provided.

@baltzell baltzell added this to the Real Run Number Simulations milestone Oct 23, 2025
@baltzell baltzell added the gemc label Oct 23, 2025
@baltzell baltzell force-pushed the detector-changed-hook branch 2 times, most recently from b9beea1 to 509c95a Compare November 13, 2025 22:14
Nathan Baltzell and others added 26 commits November 13, 2025 18:25
@baltzell
remove unused stuff
989ac4a
@baltzell
add detectorChanged method (and remove unused imports)
0117884
@baltzell
fix formatting
2af4287
@baltzell
implement all detectorChanged hooks (and cleanup/formatting)
f800157
@baltzell
synchronize and count changes
d3700e7
@baltzell
allow nulls
823db98
@baltzell
add empty list check
8502402
@baltzell
cleanup/formatting
08a295b
@baltzell
use the same wrapper used in clara/recon-util
131cdd6
@baltzell
hardcode it to 11 for now
43e62c6
@baltzell
implement detectorChanged for cvt
15c1723
@baltzell
implement detector changed for dc
bb8ddce
@baltzell
use the same wrapper used in clara/recon-util
e7a1a6a
@baltzell
fix logic oops
94719c5
@baltzell
rename processDataEvent/processEvent
e202ef3
@baltzell
make MLTDEngine respect run number like everyone else, unless overrid…
3983ca8 
…en from YAML
@baltzell
add newly-required methods
1e29365
@baltzell
restore initialization
51da63d
@baltzell
allow run number override from YAML
8dee7f5
@baltzell
add missing overrides
2860815
@baltzell
remove mc/data check
9021763
@baltzell
fix overrides (maintainence of never-ending PR)
38888bf
@baltzell
processDataEvent should be final
c0ae2c2
@baltzell
cleanup script
0ab6349
@baltzell
remove unused/unnecessary script
bee1d5d
@baltzell
disable workflow for now
29a38f8
baltzell and others added 22 commits November 13, 2025 18:25
@baltzell
add neutron test
8ea7ed2
@baltzell
remove leftovers
15c92c2
@baltzell
abort on error
b2bef81
@baltzell
fix rebase mistake
e10cafd
@baltzell
add missing overrides
3fdb639
@baltzell
add missing overrides
839893c
@baltzell
add missing overrides
741add6
@raffaelladevita @baltzell
accounting for tstart, tflight and tprop in MC tracks reconstruction
2caf0a1
@raffaelladevita @baltzell
removed check on run number when setting the DC hit uncertainty
b4602eb
@raffaelladevita @baltzell
removed hardcoded change to default variation in BAND engine
c7d44cf
@raffaelladevita @baltzell
apply TDC jitter correction only if TI timestamp is >0, excluding MC …
21546ff 
…events
@raffaelladevita @baltzell
moved RF offsets to time written to RUN::rf bank
ba57588
@raffaelladevita @baltzell
fixed bug in REC::Event.RFTime introduced with last commit
6a509e3
@raffaelladevita @baltzell
restored TDC jitter correction for timestamp=0
62e7683
@raffaelladevita @baltzell
switch to load geometry for real run number
17b7842
@baltzell
fix env
c3be1bf
@baltzell
add missing override
b624057
@baltzell
remove unused imports
b5e1a47
@baltzell
set PATH
a712090
@baltzell
add missing overrides
f863a1e
@baltzell
add missing overrides
f680248
@raffaelladevita @baltzell
propagate detectorChanged and method renaming to new UberEngine
8492640
@baltzell baltzell force-pushed the detector-changed-hook branch from 509c95a to 8492640 Compare November 13, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raffaelladevita raffaelladevita Awaiting requested review from raffaelladevita raffaelladevita will be requested when the pull request is marked ready for review raffaelladevita is a code owner

@c-dilks c-dilks Awaiting requested review from c-dilks c-dilks will be requested when the pull request is marked ready for review c-dilks is a code owner

@zieglerv zieglerv Awaiting requested review from zieglerv zieglerv will be requested when the pull request is marked ready for review zieglerv is a code owner

@tongtongcao tongtongcao Awaiting requested review from tongtongcao tongtongcao will be requested when the pull request is marked ready for review tongtongcao is a code owner

@mathieuouillon mathieuouillon Awaiting requested review from mathieuouillon mathieuouillon will be requested when the pull request is marked ready for review mathieuouillon is a code owner

@Hattawy Hattawy Awaiting requested review from Hattawy Hattawy will be requested when the pull request is marked ready for review Hattawy is a code owner

@drewkenjo drewkenjo Awaiting requested review from drewkenjo drewkenjo will be requested when the pull request is marked ready for review drewkenjo is a code owner

@mcontalb mcontalb Awaiting requested review from mcontalb mcontalb will be requested when the pull request is marked ready for review mcontalb is a code owner

@N-Plx N-Plx Awaiting requested review from N-Plx N-Plx will be requested when the pull request is marked ready for review N-Plx is a code owner

@rafopar rafopar Awaiting requested review from rafopar rafopar will be requested when the pull request is marked ready for review rafopar is a code owner

@forcar forcar Awaiting requested review from forcar forcar will be requested when the pull request is marked ready for review forcar is a code owner

@hauenst hauenst Awaiting requested review from hauenst hauenst will be requested when the pull request is marked ready for review hauenst is a code owner

@ajhobart ajhobart Awaiting requested review from ajhobart ajhobart will be requested when the pull request is marked ready for review ajhobart is a code owner

@silvianic silvianic Awaiting requested review from silvianic silvianic will be requested when the pull request is marked ready for review silvianic is a code owner

@mpaolone mpaolone Awaiting requested review from mpaolone mpaolone will be requested when the pull request is marked ready for review mpaolone is a code owner

@efuchey efuchey Awaiting requested review from efuchey efuchey will be requested when the pull request is marked ready for review efuchey is a code owner

@whit2333 whit2333 Awaiting requested review from whit2333 whit2333 will be requested when the pull request is marked ready for review whit2333 is a code owner

@ftouchte ftouchte Awaiting requested review from ftouchte ftouchte will be requested when the pull request is marked ready for review ftouchte is a code owner

@heddle heddle Awaiting requested review from heddle heddle will be requested when the pull request is marked ready for review heddle is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

gemc

Projects

None yet

Milestone

Real Run Number Simulations

Development

Successfully merging this pull request may close these issues.

3 participants

@baltzell @raffaelladevita