Skip to content

Commit c003833

Browse files
c-dilksc-dilks
committed
fix: actuallly back to rank 7
1 parent 2a087a0 commit c003833

File tree

2 files changed

+49
-44
lines changed

2 files changed

+49
-44
lines changed

‎common-tools/cnuphys/splot/src/main/java/cnuphys/splot/plot/PlotCanvas.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ public PlotCanvas(DataSet dataSet, String plotTitle, String xLabel, String yLabe
151151
}
152152
catch (DataSetException e) {
153153
e.printStackTrace();
154-
System.exit(1);
155154
}
156155
}
157156

‎spotbugs-exclude.xml‎

Lines changed: 49 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -28,51 +28,57 @@
2828
<Class name="eu.mihosoft.vrl.v3d.ext.openjfx.shape3d.symbolic.SymbolicPolygonMesh"/>
2929
</Match>
3030

31-
<!-- RANK 8 SUPPRESSIONS -->
32-
<Match> <!-- the pattern `while(phi > 360) phi -= 360.0;` -->
33-
<Bug pattern="FL_FLOATS_AS_LOOP_COUNTERS"/>
34-
</Match>
35-
<Match> <!-- ignore this static method hiding -->
36-
<Bug pattern="HSM_HIDING_METHOD"/>
37-
<Class name="cnuphys.splot.plot.VerticalLabelUI"/>
38-
<Method name="createUI"/>
39-
</Match>
40-
<Match> <!-- not quite a singleton pattern -->
41-
<Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/>
42-
<Class name="cnuphys.splot.plot.VerticalLabelUI"/>
43-
</Match>
44-
<Match> <!-- singleton implements Serializable; should use enum singleton pattern -->
45-
<Bug pattern="SING_SINGLETON_IMPLEMENTS_SERIALIZABLE"/>
46-
<Class name="cnuphys.lund.LundTrackDialog"/>
47-
</Match>
48-
<Match> <!-- singleton implements Serializable; should use enum singleton pattern -->
49-
<Bug pattern="SING_SINGLETON_IMPLEMENTS_SERIALIZABLE"/>
50-
<Class name="cnuphys.swim.SwimMenu"/>
51-
</Match>
52-
<Match> <!-- static method hiding of base-class DetectorResponse.readHipoEvent -->
53-
<Bug pattern="HSM_HIDING_METHOD"/>
54-
<Class name="org.jlab.clas.detector.TaggerResponse"/>
55-
<Method name="readHipoEvent" params="org.jlab.io.base.DataEvent,String,org.jlab.detector.base.DetectorType"\>
56-
</Match>
57-
<Match> <!-- static method hiding of base-class DetectorResponse.readHipoEvent -->
58-
<Bug pattern="HSM_HIDING_METHOD"/>
59-
<Class name="org.jlab.clas.detector.ScintillatorResponse"/>
60-
<Method name="readHipoEvent" params="org.jlab.io.base.DataEvent,String,org.jlab.detector.base.DetectorType"\>
61-
</Match>
62-
<Match> <!-- static method hiding of base-class DetectorResponse.readHipoEvent -->
63-
<Bug pattern="HSM_HIDING_METHOD"/>
64-
<Class name="org.jlab.clas.detector.CherenkovResponse"/>
65-
<Method name="readHipoEvent" params="org.jlab.io.base.DataEvent,String,org.jlab.detector.base.DetectorType"\>
66-
</Match>
67-
<Match> <!-- static method hiding of base-class DetectorResponse.readHipoEvent -->
68-
<Bug pattern="HSM_HIDING_METHOD"/>
69-
<Class name="org.jlab.clas.detector.CalorimeterResponse"/>
70-
<Method name="readHipoEvent" params="org.jlab.io.base.DataEvent,String,org.jlab.detector.base.DetectorType"\>
71-
</Match>
72-
<Match> <!-- since DefaultLogger may be deprecated soon; FIXME: this filter doesn't seem to work -->
73-
<Class name="org.jlab.logging.DefaultLogger"/>
31+
<!-- RANK 7 SUPPRESSIONS -->
32+
<Match> <!-- seems that @Nullable is no longer enough to suppress -->
33+
<Bug pattern="NP_NULL_PARAM_DEREF_NONVIRTUAL"/>
34+
<Class name="org.jlab.service.ltcc.LTCCHit"/>
7435
</Match>
7536

37+
<!-- RANK 8 SUPPRESSIONS -->
38+
<!-- <Match> --> <!-- the pattern `while(phi > 360) phi -= 360.0;` -->
39+
<!-- <Bug pattern="FL_FLOATS_AS_LOOP_COUNTERS"/> -->
40+
<!-- </Match> -->
41+
<!-- <Match> --> <!-- ignore this static method hiding -->
42+
<!-- <Bug pattern="HSM_HIDING_METHOD"/> -->
43+
<!-- <Class name="cnuphys.splot.plot.VerticalLabelUI"/> -->
44+
<!-- <Method name="createUI"/> -->
45+
<!-- </Match> -->
46+
<!-- <Match> --> <!-- not quite a singleton pattern -->
47+
<!-- <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/> -->
48+
<!-- <Class name="cnuphys.splot.plot.VerticalLabelUI"/> -->
49+
<!-- </Match> -->
50+
<!-- <Match> --> <!-- singleton implements Serializable; should use enum singleton pattern -->
51+
<!-- <Bug pattern="SING_SINGLETON_IMPLEMENTS_SERIALIZABLE"/> -->
52+
<!-- <Class name="cnuphys.lund.LundTrackDialog"/> -->
53+
<!-- </Match> -->
54+
<!-- <Match> --> <!-- singleton implements Serializable; should use enum singleton pattern -->
55+
<!-- <Bug pattern="SING_SINGLETON_IMPLEMENTS_SERIALIZABLE"/> -->
56+
<!-- <Class name="cnuphys.swim.SwimMenu"/> -->
57+
<!-- </Match> -->
58+
<!-- <Match> --> <!-- static method hiding of base-class DetectorResponse.readHipoEvent -->
59+
<!-- <Bug pattern="HSM_HIDING_METHOD"/> -->
60+
<!-- <Class name="org.jlab.clas.detector.TaggerResponse"/> -->
61+
<!-- <Method name="readHipoEvent" params="org.jlab.io.base.DataEvent,String,org.jlab.detector.base.DetectorType"\> -->
62+
<!-- </Match> -->
63+
<!-- <Match> --> <!-- static method hiding of base-class DetectorResponse.readHipoEvent -->
64+
<!-- <Bug pattern="HSM_HIDING_METHOD"/> -->
65+
<!-- <Class name="org.jlab.clas.detector.ScintillatorResponse"/> -->
66+
<!-- <Method name="readHipoEvent" params="org.jlab.io.base.DataEvent,String,org.jlab.detector.base.DetectorType"\> -->
67+
<!-- </Match> -->
68+
<!-- <Match> --> <!-- static method hiding of base-class DetectorResponse.readHipoEvent -->
69+
<!-- <Bug pattern="HSM_HIDING_METHOD"/> -->
70+
<!-- <Class name="org.jlab.clas.detector.CherenkovResponse"/> -->
71+
<!-- <Method name="readHipoEvent" params="org.jlab.io.base.DataEvent,String,org.jlab.detector.base.DetectorType"\> -->
72+
<!-- </Match> -->
73+
<!-- <Match> --> <!-- static method hiding of base-class DetectorResponse.readHipoEvent -->
74+
<!-- <Bug pattern="HSM_HIDING_METHOD"/> -->
75+
<!-- <Class name="org.jlab.clas.detector.CalorimeterResponse"/> -->
76+
<!-- <Method name="readHipoEvent" params="org.jlab.io.base.DataEvent,String,org.jlab.detector.base.DetectorType"\> -->
77+
<!-- </Match> -->
78+
<!-- <Match> --> <!-- since DefaultLogger may be deprecated soon; FIXME: this filter doesn't seem to work -->
79+
<!-- <Class name="org.jlab.logging.DefaultLogger"/> -->
80+
<!-- </Match> -->
81+
7682
<!-- HIGHER RANK SUPPRESSIONS -->
7783
<!-- <Match> --> <!-- not worth fixing -->
7884
<!-- <Class name="cnuphys.snr.ExtendedWord"/> -->

0 commit comments

Comments
 (0)