Skip to content

Commit 2a087a0

Browse files
committed
fix: remove commented out code
1 parent d365126 commit 2a087a0

File tree

3 files changed

+0
-69
lines changed

3 files changed

+0
-69
lines changed

common-tools/clas-utils/src/main/java/org/jlab/utils/system/ClasUtilsFile.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -133,27 +133,6 @@ public static List<String> getFileList(String env, String rpath){
133133
return ClasUtilsFile.getFileList(directory);
134134
}
135135

136-
// FIXME: unused, and spotbugs detects rank-7 bug `NP_NULL_PARAM_DEREF_NONVIRTUAL`;
137-
// should we just remove this function?
138-
// /**
139-
// * returns a file list that contains files with given extension
140-
// * @param env
141-
// * @param rpath
142-
// * @param ext
143-
// * @return
144-
// */
145-
// public static List<String> getFileList(String env, String rpath, String ext){
146-
// String directory = ClasUtilsFile.getResourceDir(env, rpath);
147-
// if(directory!=null) return new ArrayList<>();
148-
//
149-
// List<String> files = ClasUtilsFile.getFileList(directory);
150-
// List<String> selected = new ArrayList<>();
151-
// for(String item : files){
152-
// if(item.endsWith(ext)==true) selected.add(item);
153-
// }
154-
// return selected;
155-
// }
156-
157136
public static void writeFile(String filename, List<String> lines){
158137
System.out.println("writing file ---> " + filename);
159138
BufferedWriter writer = null;

reconstruction/dc/src/main/java/org/jlab/rec/dc/track/fit/StateVecsDoca.java

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -319,30 +319,6 @@ private void delA_delt(double tx, double ty, double Bx, double By, double Bz, do
319319

320320
private double beta = 1.0;
321321

322-
// FIXME: `mass` parameter is dead upon entry but overwritten
323-
// (spotbugs bug `IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN`)
324-
// Can we just remove this?
325-
// public void setMass(int hypo, double mass) {
326-
//
327-
// switch (hypo) {
328-
// case 0:
329-
// mass = 0.000510998;
330-
// break;
331-
// case 1:
332-
// mass = 0.13957018;
333-
// break;
334-
// case 2:
335-
// mass = 0.493677;
336-
// break;
337-
// case 3:
338-
// mass = 0.105658369;
339-
// break;
340-
// case 4:
341-
// mass = 0.938272029;
342-
// break;
343-
// }
344-
// }
345-
346322

347323
/**
348324
*

reconstruction/fmt/src/main/java/org/jlab/rec/fmt/track/fit/StateVecs.java

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -294,30 +294,6 @@ private void delA_delt(double tx, double ty, double Bx, double By, double Bz, do
294294

295295
private double beta = 1.0;
296296

297-
// FIXME: `mass` parameter is dead upon entry but overwritten
298-
// (spotbugs bug `IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN`)
299-
// Can we just remove this?
300-
// public void setMass(int hypo, double mass) {
301-
//
302-
// switch (hypo) {
303-
// case 0:
304-
// mass = 0.000510998;
305-
// break;
306-
// case 1:
307-
// mass = 0.13957018;
308-
// break;
309-
// case 2:
310-
// mass = 0.493677;
311-
// break;
312-
// case 3:
313-
// mass = 0.105658369;
314-
// break;
315-
// case 4:
316-
// mass = 0.938272029;
317-
// break;
318-
// }
319-
// }
320-
321297

322298
/**
323299
*

0 commit comments

Comments
 (0)