Add -A option to ps command to list all Fire TV processes #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mano3m
changed the title
JeffLIrion
reviewed
Jan 7, 2024
androidtv/constants.py
Outdated
| @@ -209,7 +209,7 @@ class DeviceEnum(IntEnum): | |||
| CMD_RUNNING_APPS_ANDROIDTV = "ps -A | grep u0_a" | |||
|
|
|||
| #: Get the running apps for a Fire TV device | |||
| CMD_RUNNING_APPS_FIRETV = "ps | grep u0_a" | |||
| CMD_RUNNING_APPS_FIRETV = "ps -A | grep u0_a" | |||
There was a problem hiding this comment.
A unit test is failing because this constant is the same as CMD_RUNNING_APPS_ANDROIDTV.
There was a problem hiding this comment.
You want me to remove the FIRETV constant and refer to the ANDROIDTV one from everywhere? Or I can add an extra space somewhere ;)
There was a problem hiding this comment.
Please consolidate the two into a single CMD_RUNNING_APPS.
|
@JeffLIrion do you need more to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102565 and #292 and updates e8b09aa