Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map states from nl.nlziet app #277

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Conversation

berendhaan
Copy link
Contributor

These were the only states I found that were usable to map to the playing / paused state. #12

If you need any more information I'm happy to help!

@berendhaan
Copy link
Contributor Author

@JeffLIrion I'm not sure why my change could trigger a failing linter. The original file already contained some very long lines.

@JeffLIrion
Copy link
Owner

Please add unit tests to cover your changes. You can use this as a guide:

# Netflix
self.assertUpdate(
[True, True, constants.STATE_IDLE, 2, constants.APP_NETFLIX, 2, "hmdi_arc", False, 30, None, None],
(constants.STATE_PAUSED, constants.APP_NETFLIX, [constants.APP_NETFLIX], "hmdi_arc", False, 0.5, None),
)
self.assertUpdate(
[True, True, constants.STATE_IDLE, 2, constants.APP_NETFLIX, 3, "hmdi_arc", False, 30, None, None],
(constants.STATE_PLAYING, constants.APP_NETFLIX, [constants.APP_NETFLIX], "hmdi_arc", False, 0.5, None),
)

@berendhaan
Copy link
Contributor Author

Done :-) All checks are green.

@JeffLIrion JeffLIrion merged commit 6ac4ebf into JeffLIrion:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants