-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
11 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
'react-select': patch | ||
--- | ||
|
||
Use an internal member to check if control onMouseDown should act and remove logic to bail out from an event if someone else listening to the event (usually in a capture phase) has called preventDefault(). | ||
|
||
This change was initiated to fix the interop between react-select and react-beautiful-dnd. | ||
But has meaning on its own because it is pretty clear that using the `defaultPrevented` event property for custom logic is a really bad practice. | ||
So, another way to filter when we want to trigger control onMouseDown normal logic has to be better defined and developed. | ||
|
||
Nothing to update from the consumers. |