Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to adds support for Amazon Simple Notification Service (SNS). Mentioned in the issue SNS topic support for the SQS transport #58
So far my plan is to create a separate transport for SNS instead of adding it to the current SQS support.
So far here are my cons and pros of creating a separate transport:
Pros
If we were to merge it all into the
AmazonSqsTransport
class, we would need to create a separate field for the Client (IAmazonSQS
/IAmazonSimpleNotificationService
), Config (AmazonSQSConfig
/AmazonSimpleNotificationServiceConfig
). The queue/topic creation configuration and attributes would also be different for each endpoint.Cons
I had envisioned the ability to create a SNS topic, configure a subscription to a SQS queue and then configure a listener on that same queue all within wolverine. Storing the queues and topics in 2 different transports, just makes this a little more difficult.