Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra player bio info from transfermarkt [Closes #141] v2 #416

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

tonyelhabr
Copy link
Collaborator

Re-do'ing #414 since I'm unable to rebase that branch properly with changes.

Code changes in there were all good. Only addition is incrementing package version to 0.6.7.0002.

@tonyelhabr tonyelhabr requested a review from JaseZiv February 10, 2025 15:09
Copy link
Owner

@JaseZiv JaseZiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff.

@tonyelhabr tonyelhabr merged commit 4d6bd1a into main Feb 11, 2025
0 of 2 checks passed
@aymennasri
Copy link
Contributor

@tonyelhabr why am i not mentioned in the commits as the author of these changes?

@tonyelhabr
Copy link
Collaborator Author

@tonyelhabr why am i not mentioned in the commits as the author of these changes?

sorry about that! i thought i had cherrypicked the commit, but apparently not.

if you'd like, you can add yourself to the Authors@R part of the DESCRIPTION file since your contributions have been pretty non-trivial imo.

more broadly, i'd love to have more active contributors / maintainers as well, if you're up for it.

@aymennasri
Copy link
Contributor

@tonyelhabr why am i not mentioned in the commits as the author of these changes?

sorry about that! i thought i had cherrypicked the commit, but apparently not.

if you'd like, you can add yourself to the Authors@R part of the DESCRIPTION file since your contributions have been pretty non-trivial imo.

more broadly, i'd love to have more active contributors / maintainers as well, if you're up for it.

Would love to be added to the Authors@R part in the DESCRIPTION file and if there's any prioritized work to-do, do let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants