Add suspensions from transfermarkt [Closes #411]

[aymennasri]

Added a half baked solution to #411 as I tried my best to match the authors approach in other functions.
get_risk_of_suspension() with a url is the only thing working and I will need assistance if the author deems the pull request worthy enough.

[aymennasri]

Fixed everything with the functions, should be ready to merge [Closes #411]

[tonyelhabr]

is it possible to add a unit test?

[aymennasri]

for what exactly?

[tonyelhabr]

for what exactly?

for the functions added in this PR. something as simple as checking rows in an example call, e.g. here

[aymennasri]

for what exactly?

for the functions added in this PR. something as simple as checking rows in an example call, e.g. here

@tonyelhabr You can't really predict the number of suspensions in a legaue and it changes constantly alongside other stats, which makes a lot of the tests in the package to be faulty. (like the injuries in a league)

For example, the Premier League has no suspended players for now but that doesn't mean that the function is faulty.

[JaseZiv]

for what exactly?

for the functions added in this PR. something as simple as checking rows in an example call, e.g. here

@tonyelhabr You can't really predict the number of suspensions in a legaue and it changes constantly alongside other stats, which makes a lot of the tests in the package to be faulty. (like the injuries in a league)

For example, the Premier League has no suspended players for now but that doesn't mean that the function is faulty.

@aymennasri you don't just need to test for row numbers... you can also write unit tests to ensure the columns/data points you're wanting to scrape are still being presented (even if no data for the particular player)...

[JaseZiv]

@aymennasri can you also increment the patch number of the package version in DESCRIPTION for all PRs based on which order you want the three PRs matched (#412, #413, #414). See here for an explainer on versioning. For the PR that will ultimately create the latest version, can you also update NEWS.md, following the same conventions we're using in there? Thanks

[aymennasri]

for what exactly?

for the functions added in this PR. something as simple as checking rows in an example call, e.g. here

@tonyelhabr You can't really predict the number of suspensions in a legaue and it changes constantly alongside other stats, which makes a lot of the tests in the package to be faulty. (like the injuries in a league)
For example, the Premier League has no suspended players for now but that doesn't mean that the function is faulty.

@aymennasri you don't just need to test for row numbers... you can also write unit tests to ensure the columns/data points you're wanting to scrape are still being presented (even if no data for the particular player)...

Done.

[tonyelhabr]

lgtm. tested out the code for various leagues and it seemed to work fine. i added examples and code to the vignette

[JaseZiv]

Thanks so much for reviewing this @tonyelhabr.

[aymennasri]

@tonyelhabr @JaseZiv is there anything i should change in order to have my PRs merged?

[tonyelhabr]

test failures are unrelated