Precompile vignette to pass CRAN #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaseZiv
approved these changes
Oct 5, 2024
|
You probably want to re-activate the check Action https://github.com/JaseZiv/chessR/actions/workflows/R-CMD-check.yaml I'm actually thinking that the figure path I used isn't portable (on Windows) so I'm adding a new very small PR to make that more general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precompile the vignette, which requires network access and potentially takes too long.
This (via
vignettes/precompile.R) knits the vignette (.Rmd.orig) into a new.Rmdwith the results inserted where they would appear, and the code changed to non-evaluating. Also includes some code to move the figures to the right directory.This can now be rendered on installation without requiring network access, but does require the developer to re-run it occasionally.
I also reduced the number of games returned from lichess since that was taking a long time, and fixed one inconsequential typo in a chunk name.
Addresses #17, hopefully suitable for a re-submission to CRAN.