Set transparent background for menu-items-section in media menu #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The menu-items-section box of the media menu was not transparent by default. Usually it is fully shadowed by its child "menu-content". The color and tint of the can be configured by the user. However, because the menu-items-section box behind the card had a solid color, it was impossible to configure a transparent card.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The menu-items-section box of the media menu was not transparent by default. Usually it is fully shadowed by its child "menu-content". The color and tint of the can be configured by the user. However, because the menu-items-section box behind the card had a solid color, it was impossible to configure a transparent card.
Before, a tint of 0 or just setting the color to full transparency (in the imported theme) would result in this:
With this commit, this is possible:
Maybe I misunderstand the tint and color fields of the "card", but I believe this is how it was intended in the first place.
If it was not (maybe it should be possible to tint an album art to be darker, while not making it transparent), I can also try to change the PR. This would likely need to introduce a new configurable value, like "card/album tint color" or something similar, which I would configure to be fully transparent for my purposes.