Allow reading of config with nested JSON #788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you merge my branch |
|
I have updated my branch with your patch, so the CI should (hopefully) pass now. I have also removed some comments which no longer made sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #497, and contains equivalent changes. It removes the conflict, so it's possible to merge now.
This PR allows HyprPanel to read conventional JSON objects from the configuration file, while keeping the dot-notation as used currently. This means it should not break existing workflows. The behaviour with writing to the configuration file is not changed.
Should also fix #433, as I was running into the same issue.