Add live reloading of configuration file #684
Open
+131
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the need for a file with all the available configuration and a shadow configuration file. Additionally, added several improvements: 1. Reduce I/O on initial configuration loading by only reading file once 2. Remove unnecesary back and forth events when editing configuration
|
Kind of closes #381, as it is now way nicer to edit these types of configuration, but im not sure :) |
|
Nice! I'll review this over the weekend when I get more time. |
davfsa
commented
Jan 3, 2025
davfsa
commented
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the need for a file with all the available configuration and a shadow configuration file.
Additionally, added several improvements:
There were also old references to a "cache file", which is no longer a thing since the Astal migration, so renamed those too
Closes #787 - The slowdown is caused by the massive I/O, which this pr fixed. There will still be a delay because they are not updated in bulk, but will be wayyyyy less