refactor(praxis): split comment hygiene into its own skill (#39) - #51
Conversation
code-hygiene bundled comment truthfulness with dead code, reinvention, naming and faking-done, so a diff that only needed the comment rules did not reliably auto-activate the skill (#39). Comments, tombstone and retold-fact detection, and comment density now live in their own comment-hygiene skill; find-duplicate-comments.js moves with them. Cross-references updated across code-structure, readable-code, docs-patterns and general-reviewer (frontmatter skills: list plus the Important/Minor bullets that were comment-specific). Content is moved, not rewritten -- artifact-only, no new doctrine. praxis bumped 1.4.0 -> 1.5.0 (new skill, minor per RELEASING.md). Codex face: neither .claude-plugin/plugin.json nor .codex-plugin enumerates skills, so no manifest entry to add; general-reviewer.toml regenerated because its source .md body and skills: list changed. Refs JAR-413 Co-authored-by: multica-agent <github@multica.ai>
|
Path dependency worth naming before either of these merges. This renames Whichever merges second needs the rebase, and it is a two-line one: the test file moves to I would rather this one go first, since it is the rename and #52 is additive -- but either order works as long as the second one rebases rather than merging over it. Merged over, the Separately, and not a blocker here: this implements JAR-390, which is sitting in |
Closes #39.
What
Splits comment hygiene out of
code-hygieneinto its owncomment-hygieneskill, so a diff that only needs the comment rules (KEEP/DELETE/EXEMPT/
CONDITIONAL, tombstone and retold-fact detection, comment density) doesn't
depend on the model separately deciding
code-hygiene's dead-code/naming/faking-done content is also relevant to trigger it -- the concern #39 raised.
find-duplicate-comments.jsmoves with it (it only serves the Retold-factcheck).
Cross-references updated so the split doesn't leave dangling pointers:
code-structure,readable-code,docs-patternsandgeneral-reviewer(both its frontmatter
skills:list and the Important/Minor bullets thatwere comment-specific).
Domain-owner clause
Artifact-only. Every sentence in
comment-hygiene/SKILL.mdis existing,already-approved
code-hygienecontent relocated verbatim; the only newprose is mechanical connective tissue (a one-line "split from code-hygiene"
note, and cross-file pointer edits so
code-structure/readable-code/docs-patterns/general-reviewerresolve to the new skill instead of theold one). No new rule, test, or verdict is introduced.
Not bundled here: the issue's own comment asks to "Add no-narrativization
anti-pattern." That's new doctrine, not a relocation, so it needs a content
owner's sign-off before it lands -- routing to Ferro (engineering practice)
rather than deciding it myself. Flagged, not actioned, in this PR.
Manifest / Codex face
praxisbumped1.4.0->1.5.0(new skill, MINOR perRELEASING.md)..claude-plugin/marketplace.jsondescription forpraxisstilldescribes the plugin as shipped ("code review with specialized reviewers,
and project conventions") -- no update needed.
.claude-plugin/plugin.jsonnor.codex-pluginenumerates skills (Codex defaults to
./skills, matching our layout), sothere's no manifest entry to add for the new skill directory.
general-reviewer.tomlregenerated viascripts/generate-codex.pybecause its source
.mdbody andskills:frontmatter changed (thecomment-hygieneskill reference and the reworded bullets).Verification
Task JAR-413.