Add 2 new exports: get Guild by role ID and Role name from role ID #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindGuildForRole(roleId) RoleNameFromId(id, guild)
JaredScar
requested changes
Sep 1, 2024
| function FindGuildForRole(roleId) | ||
| local roleFound | ||
| local tempGuildList = Config.Guilds | ||
| tempGuildList["main_guild_abcd1010"] = Config.Guild_ID |
Owner
There was a problem hiding this comment.
Lol, what is the need for this arbitrary key in the table?
Contributor
Author
There was a problem hiding this comment.
Mostly to make it unlikely that a user would overwrite that key in the config by 'injecting' the main guild ID in a nonsensical key
| return roleFound | ||
| end | ||
|
|
||
| function RoleNameFromId(id, guild) |
Owner
There was a problem hiding this comment.
guild should be an optional parameter?
Contributor
Author
There was a problem hiding this comment.
It is - looking below the case of guild == nil is handled by defaulting to searching for the guild. Providing the guild would just make it more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a few use cases for these functions come up, so https://github.com/R3site created these, and I applied some modifications so they'd be suitable for general use.
Usage:
exports['Badger_Discord_API']:FindGuildForRole(roleId): returns guild ID of the guild which has the provided role (if one exists).exports['Badger_Discord_API']:RoleNameFromId(roleid,guild): returns the role name of given role ID. The guild argument is optional and if not included will use FindGuildForRole to seek that role name.