Skip to content

correct BarSelect.value types to match option keys #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JannisX11 merged 2 commits into from
Jan 10, 2026
Merged

correct BarSelect.value types to match option keys #3230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5b25e9
correct BarSelect value type for blockbench-types
pklito Jan 1, 2026
d84202a
Fix one more type
JannisX11 Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions types/custom/action.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,18 +523,18 @@ declare global {
get(): number
}
interface BarSelectOptions<T> extends WidgetOptions {
value?: T
value?: string
options: Record<string, T>
}
class BarSelect<T> extends Widget {
constructor(id: string, options: BarSelectOptions<T>)
open(event: Event): void
trigger(event: Event): boolean | undefined
change(value: T, event: Event): this
change(value: string, event: Event): this
getNameFor(key: string): string
set(key: string): this
get(): string
value: T
value: string
}
class BarText extends Widget {
constructor(
Expand Down