Skip to content

Normalize macOS Delete code (8) to the 46 which Windows/Unix uses #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nedtwigg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Normalize macOS Delete code (8) to the 46 which Windows/Unix uses #3120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion js/interface/keyboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,12 @@ addEventListeners(document, 'keydown mousedown', function(e) {
if (Keybinds.recording || e.which < 4) return;
//Shift


// Normalize Backspace/Delete key (8) to Delete keycode (46) when not in text input
// On macOS, the Delete key above Return sends keycode 8
if (e.which === 8 && !getFocusedTextInput()) {
Object.defineProperty(e, 'which', {value: 46, writable: false, configurable: true});
}

let modifiers_changed = Pressing.shift != e.shiftKey || Pressing.alt != e.altKey || Pressing.ctrl != e.ctrlKey;
let before = modifiers_changed && {shift: Pressing.shift, alt: Pressing.alt, ctrl: Pressing.ctrl};
Pressing.shift = e.shiftKey;
Expand Down